Log Gracefully and ignore entity id null error#27459
Merged
mohityadav766 merged 4 commits intomainfrom Apr 18, 2026
Merged
Conversation
github-actions
Bot
added
backend
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce noisy/avoidable errors by (1) logging WebSocket disconnect-related exceptions more gracefully and (2) avoiding failures when recording search-index reader errors that don’t have a usable entity id.
Changes:
- Update Jetty 12 WebSocket error handling to downgrade
ClosedChannelExceptionlogging and add safer logging around error handling. - Update distributed search indexing
PartitionWorkerto deriveentityIdmore intentionally (preferEntityInterface.getId()) and skip recording reader failures whenentityIdis null.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openmetadata-service/src/main/java/org/openmetadata/service/socket/Jetty12WebSocketHandler.java | Adjusts WebSocket error logging to treat closed-channel errors as non-actionable noise and wraps error handling defensively. |
| openmetadata-service/src/main/java/org/openmetadata/service/apps/bundles/searchIndex/distributed/PartitionWorker.java | Changes how reader failures derive entityId and adds a skip path when an id can’t be determined. |
Code Review ✅ Approved 1 resolved / 1 findingsGraceful logging implemented for null entity IDs, resolving the panic caused by emitting messages on closed channels. No further issues found. ✅ 1 resolved✅ Bug: emit() called on closed channel with null message
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
pmbrull
approved these changes
Apr 17, 2026
Contributor
🟡 Playwright Results — all passed (26 flaky)✅ 3659 passed · ❌ 0 failed · 🟡 26 flaky · ⏭️ 89 skipped
🟡 26 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
mohityadav766
added a commit
that referenced
this pull request
Apr 22, 2026
* Log Gracefully and ignore entity id null error * Ignore in recorder * Review comments addressed (cherry picked from commit 35c3c92)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>